Add missing segwit BSQ keychain path to wallet info #6604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the new account path "44'/142'/1'" for segwit BSQ to the wallet info view, which was missed from PR bisq-network#5109 making the wallet & UI changes to implement segwit BSQ. Also format the paths from the constants defined in 'BisqKeyChainGroupStructure', instead of using string literals, so that they are only defined in one place. (Though it is extremely unlikely the paths would ever change.)
Add private method 'WalletInfoView.addAccountPaths', similar to the method 'addXpubKeys', to iterate over the active wallet keychains, formatting & displaying the derivation paths, instead of using the 4 constants defined in BisqKeyChainGroupStructure. Also simplify the code slightly by updating the 'gridRow' field directly instead of passing it as a method argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new account path
44'/142'/1'for segwit BSQ to the wallet info view, which was missed from PR #5109 making the wallet & UI changes to implement segwit BSQ. Also format all the paths found by iterating over the active wallet keychains, which are set to the constant lists defined inBisqKeyChainGroupStructure, instead of using hard-coded string literals. In this way, the four paths are only defined in one place (though it is extremely unlikely they would ever change).